[PATCH] D63058: [InlineCost] Fix bug 42084: return the first negative result

Fedor Sergeev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 17 03:33:49 PDT 2019


fedor.sergeev added a comment.

In D63058#1543122 <https://reviews.llvm.org/D63058#1543122>, @yrouban wrote:

> One issue bothers me: results of the InlineCost analyzer will depend on the flag //ComputeFullInlineCost//. Negative or positive decision will persist but the message and highest computed cost will be changing.


We already have the cost difference depending on this flag.
It seems to be rather obvious consequence of "full inline cost" notion and the difference should not be confusing...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63058/new/

https://reviews.llvm.org/D63058





More information about the llvm-commits mailing list