[PATCH] D63493: [yaml2obj] - Convert `ELFState<ELFT>::addSymbols` method to `toELFSymbols` helper.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 19 04:05:28 PDT 2019


jhenderson added inline comments.


================
Comment at: tools/yaml2obj/yaml2elf.cpp:383
+  Ret.resize(Symbols.size() + 1);
+  memset(&Ret[0], 0, sizeof(Elf_Sym) * Ret.size());
+
----------------
Do you need this? I think the vector resize will do this automatically, if I'm not mistaken.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63493/new/

https://reviews.llvm.org/D63493





More information about the llvm-commits mailing list