[PATCH] D63493: [yaml2obj] - Convert `ELFState<ELFT>::addSymbols` method to `toELFSymbols` helper.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 18 06:59:21 PDT 2019


grimar created this revision.
grimar added a reviewer: jhenderson.
Herald added a subscriber: jakehehrlich.

`ELFState<ELFT>::addSymbols` method looks a bit strange.
User code have to create the destination symbols vector outside,
add a null symbol and then pass it to `addSymbols` when it seems
the more natural logic is to isolate all work with symbols inside some
function build the list there and return it.


https://reviews.llvm.org/D63493

Files:
  tools/yaml2obj/yaml2elf.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63493.205327.patch
Type: text/x-patch
Size: 4319 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190618/e6a0da44/attachment.bin>


More information about the llvm-commits mailing list