[PATCH] D63379: [Attributor] Deducing existing nounwind attribute.

[Stefan Stipanovic via Phabricator via llvm-commits]

sstefan1 marked an inline comment as done.
sstefan1 added a comment.

> Is this sufficient to replace the old nounwind deduction? Can you disable the current one to see if there is something we cannot deduce with this one?

I already tried it on some of the other tests and it worked fine. I am going to that and test it some more, and update tomorrow morning.



================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:654
+    static constexpr Attribute::AttrKind ID =
+        Attribute::AttrKind(Attribute::NoUnwind);
+
----------------
jdoerfert wrote:
> Isn't `ID = Attribute::NoUnwind` sufficient?
Totally, my bad.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63379/new/

https://reviews.llvm.org/D63379