[PATCH] D63379: [Attributor] Deducing existing nounwind attribute.

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 18 01:12:54 PDT 2019


jdoerfert added a comment.

Is this sufficient to replace the old `nounwind` deduction? Can you disable the current one to see if there is something we cannot deduce with this one?



================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:654
+    static constexpr Attribute::AttrKind ID =
+        Attribute::AttrKind(Attribute::NoUnwind);
+
----------------
Isn't `ID = Attribute::NoUnwind` sufficient?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63379/new/

https://reviews.llvm.org/D63379





More information about the llvm-commits mailing list