[PATCH] D62976: [LLD] [COFF] Add an lld specific option /includeoptional

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 7 01:29:56 PDT 2019


ruiu added a comment.

Our algorithm for the ELF -u option is as follows:

1. resolve all symbols normally
2. for each symbol given by -u, look up the symbol table, and if a returned symbol is a lazy symbol, call `fetch`

This way seems better than the way how it is implemented in this patch for the following two reasons:

1. we don't need any Config member as -u option values are consumed in-place
2. The cost of -u is proportional to the number of -u options instead of the number of (undefined) symbols


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62976/new/

https://reviews.llvm.org/D62976





More information about the llvm-commits mailing list