[PATCH] D62976: [LLD] [COFF] Add an lld specific option /includeoptional

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 7 01:42:10 PDT 2019


mstorsjo marked an inline comment as done.
mstorsjo added inline comments.


================
Comment at: COFF/SymbolTable.cpp:247
+    if (Config->AllowUnresolved.count(Name))
+      continue;
+
----------------
This won't do the right thing, if there actually are proper undefined to the same symbol as well. Any ideas/suggestions, @rnk @ruiu?


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62976/new/

https://reviews.llvm.org/D62976





More information about the llvm-commits mailing list