[PATCH] D60713: [IR] Add DISuprogram and DIE for func decl of an external

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 31 09:32:29 PDT 2019


aprantl added inline comments.


================
Comment at: lib/IR/Verifier.cpp:2228
+               !cast<DISubprogram>(I.second)->isDistinct(),
+               "function declaration may only have a unique !dbg attachment", &F);
       Assert(I.first != LLVMContext::MD_prof,
----------------
aprantl wrote:
> LGTM!
Perhaps add a comment here:
// This is used for call site debug information.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60713/new/

https://reviews.llvm.org/D60713





More information about the llvm-commits mailing list