[PATCH] D60713: [IR] Add DISuprogram and DIE for func decl of an external

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

Thanks!



================
Comment at: lib/CodeGen/AsmPrinter/DwarfDebug.cpp:672
 
+  // Create DIEs for function declaraions used for dbg call sites.
+  for (auto Scope : DIUnit->getRetainedTypes())
----------------
` Create DIEs for function declarations used for call site debug info.`


================
Comment at: lib/IR/Verifier.cpp:2228
+               !cast<DISubprogram>(I.second)->isDistinct(),
+               "function declaration may only have a unique !dbg attachment", &F);
       Assert(I.first != LLVMContext::MD_prof,
----------------
LGTM!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60713/new/

https://reviews.llvm.org/D60713