[llvm] r362012 - IR: add optional type to 'byval' function parameters

[David Blaikie via llvm-commits]

On Wed, May 29, 2019 at 1:34 PM Tim Northover <tnorthover at apple.com> wrote:

> Hi David,
>
> On 29 May 2019, at 13:31, David Blaikie <dblaikie at gmail.com> wrote:
> > Sorry about this, but Google-internal build testing is tripping over
> this change when it comes to bootstrapping compiler-rt (with some
> "Attribute 'byval' type does not match parameter!"). Did you happen to test
> a bootstrap?
>
> I’m investigating now. I believe the issue is that llvm-link (and hence
> LTO) doesn’t merge types within byval yet. I expect to have a fix in about
> an hour.
>

Ah, awesome :)


> > Reckon it's worth reverting while I investigate on my side? (or if you
> think the chances are good it's only a Google internal issue, that's fair &
> I can just try to figure out what's off with our internal build system)
>
> I’m happy to revert while I work on it if that’s too slow. Just send word
> or do it yourself, whichever is most convenient for you.
>

If you wouldn't mind reverting, that'd be great - just so CI
infrastructure's got a better chance of catching other regressions in the
interim.

- Dave
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190529/c3c0d5f4/attachment.html>