[PATCH] D62355: AMDGPU: Activate all lanes when spilling CSR VGPR for SGPR spills

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 23 18:28:06 PDT 2019


arsenm added a comment.

In D62355#1514957 <https://reviews.llvm.org/D62355#1514957>, @arsenm wrote:

> In D62355#1514932 <https://reviews.llvm.org/D62355#1514932>, @rampitec wrote:
>
> > Where do you get SGPR pair for saveexec if you need to spill an SGPR?
>
>
> LivePhysRegs takes care of this. Since this is the prologue/epilog, only the ABI registers should be live so it should be easy to find a free register. This will probably require special handling for one of the odd preserve all calling conventions that aren't supported now


To answer your question more directly, spilling should never be necessary here


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62355/new/

https://reviews.llvm.org/D62355





More information about the llvm-commits mailing list