[llvm] r361517 - [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, induction variable, and guard branch.

[Florian Hahn via llvm-commits]

> On 23 May 2019, at 21:41, Kit Barton <kbarton at ca.ibm.com> wrote:
> 
> I agree about the adjusted commit message. I’ll attempt to revert it now and will recommit once everyone is ok with the patch.
> 
> The last time I tried to revert something it did not go well. Hopefully this time will be better :)
> 

Sounds great, thanks!

> Sent from my iPhone using IBM Verse
> 
> On May 23, 2019, 4:15:35 PM, florian_hahn at apple.com wrote:
> 
> From: florian_hahn at apple.com
> To: kbarton at ca.ibm.com
> Cc: 
> Date: May 23, 2019, 4:15:35 PM
> Subject: [EXTERNAL] Re: Re: [llvm] r361517 - [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, induction variable, and guard branch.
> 
> Hi Kit,
> 
> On May 23, 2019, at 19:34, Kit Barton < kbarton at ca.ibm.com> wrote:
> 
> Hi Florian,
> I apologize - I didn't see the comments on phabricator after I had approved it, and Whitney didn't tell me there were additional comments.
>  
> 
> No worries!
> 
> Do you want me to revert the patch so she can address the comments, or should we deal with them in a follow-up patch?
>  
> 
> I don’t have any strong opinions on that and think either should be fine. Reverting it (and recommitting it later) would have the small benefit of having an adjusted commit message for git-blame & co.
> 
> I think something in the commit message tripped over Phabricator and it failed to link the commit to the Phabricator patch. Maybe it was the indentation.
> 
> Cheers,
> Florian
> 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190523/c4c75740/attachment.html>