<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div dir="ltr"></div><div dir="ltr"><br></div><div dir="ltr"><br>On 23 May 2019, at 21:41, Kit Barton <<a href="mailto:kbarton@ca.ibm.com">kbarton@ca.ibm.com</a>> wrote:<br><br></div><blockquote type="cite"><div dir="ltr"><meta http-equiv="Content-Type" content="text/html;charset=utf-8">I agree about the adjusted commit message. I’ll attempt to revert it now and will recommit once everyone is ok with the patch.<div><br></div><div>The last time I tried to revert something it did not go well. Hopefully this time will be better :)<br><br></div></div></blockquote><div><br></div>Sounds great, thanks!<div><br><blockquote type="cite"><div dir="ltr"><div>Sent from my iPhone using IBM Verse<meta name="viewport" content="initial-scale=1.1"><br><br><hr>On May 23, 2019, 4:15:35 PM, <a href="mailto:florian_hahn@apple.com">florian_hahn@apple.com</a> wrote:<br><br>From: <a href="mailto:florian_hahn@apple.com">florian_hahn@apple.com</a><br>To: <a href="mailto:kbarton@ca.ibm.com">kbarton@ca.ibm.com</a><br>Cc: <br>Date: May 23, 2019, 4:15:35 PM<br>Subject: [EXTERNAL] Re: Re: [llvm] r361517 - [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, induction variable, and guard branch.<br><br><div id="MaaS360PIMSDKOriginalMessageId">Hi Kit,<br class=""><div> <br class=""> <blockquote class=""> <div class=""> On May 23, 2019, at 19:34, Kit Barton < <a href="mailto:kbarton@ca.ibm.com" class="">kbarton@ca.ibm.com</a>> wrote: </div> <br class="Apple-interchange-newline"> <div class=""> <div class="socmaildefaultfont" style="font-family:Arial, Helvetica, sans-serif;font-size:9pt"> <div class=""> Hi Florian, </div> <div class=""> I apologize - I didn't see the comments on phabricator after I had approved it, and Whitney didn't tell me there were additional comments. </div> <div class=""> </div> </div> </div> </blockquote> <div> <br class=""> </div>No worries!</div><div> <br class=""> <blockquote class=""> <div class=""> <div class="socmaildefaultfont" style="font-family:Arial, Helvetica, sans-serif;font-size:9pt"> <div class=""> Do you want me to revert the patch so she can address the comments, or should we deal with them in a follow-up patch? </div> <div class=""> </div> </div> </div> </blockquote> <br class=""></div><div> I don’t have any strong opinions on that and think either should be fine. Reverting it (and recommitting it later) would have the small benefit of having an adjusted commit message for git-blame & co.</div><div> <br class=""></div><div> I think something in the commit message tripped over Phabricator and it failed to link the commit to the Phabricator patch. Maybe it was the indentation.</div><div> <br class=""></div><div> Cheers,</div><div> Florian</div></div></div><br>
</div></blockquote></div></body></html>