[PATCH] D61773: [RISCV] Add CFI directives for RISCV prologue/epilog.

[Alex Bradbury via Phabricator via llvm-commits]

asb added inline comments.


================
Comment at: lib/Target/RISCV/RISCVFrameLowering.cpp:125
 
+  // Emit ".cfi_def_cfa_offset StackSize"
+  unsigned CFIIndex = MF.addFrameInst(
----------------
Should say `-StackSize`?


================
Comment at: lib/Target/RISCV/RISCVFrameLowering.cpp:142
+  // directives.
+  for (std::vector<CalleeSavedInfo>::const_iterator I = CSI.begin(),
+                                                    E = CSI.end();
----------------
I think you can do this more concisely with:



```
for (const auto &Entry : CSI) {
  unsigned Reg = Entry.getReg();
  int FI = Entry.getFrameIdx();
  ....

```






Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61773/new/

https://reviews.llvm.org/D61773