[llvm] r360991 - [Analysis] Only run plugins tests if plugins are actually enabled

[Don Hinton via llvm-commits]

Since the buildbots typically don't set BUILD_SHARED_LIBS OR
LLVM_BUILD_LLVM_DYLIB, this change prevents them from building
are testing any plugins.  It also makes it impossible to
override, so I'm unable to even test bugpoint locally without
switching to shared libraries.

Therefore, I'd like to revert part of it.  Please see
https://reviews.llvm.org/D62154

Here'a an example of the messages from the bots:

from
http://lab.llvm.org:8011/builders/clang-atom-d525-fedora-rel/builds/24462/steps/cmake%20stage%201/logs/stdio

-- PrintFunctionNames ignored -- Loadable modules not supported on this
platform.
-- AnnotateFunctions ignored -- Loadable modules not supported on this
platform.
-- SampleAnalyzerPlugin ignored -- Loadable modules not supported on this
platform.
-- CheckerDependencyHandlingAnalyzerPlugin ignored -- Loadable modules not
supported on this platform.
-- CheckerOptionHandlingAnalyzerPlugin ignored -- Loadable modules not
supported on this platform.
-- BugpointPasses ignored -- Loadable modules not supported on this
platform.
-- TestPlugin ignored -- Loadable modules not supported on this platform.

On Thu, May 16, 2019 at 11:04 PM Petr Hosek via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: phosek
> Date: Thu May 16 23:07:37 2019
> New Revision: 360991
>
> URL: http://llvm.org/viewvc/llvm-project?rev=360991&view=rev
> Log:
> [Analysis] Only run plugins tests if plugins are actually enabled
>
> When plugins aren't enabled, don't try to run plugins tests. Don't
> enable plugins unconditionally based on the platform, instead check
> if LLVM shared library is actually being built which may not be the
> case for every host configuration, even if the host itself supports
> plugins.
>
> This addresses test failures introduced by r360891/D59464.
>
> Differential Revision: https://reviews.llvm.org/D62050
>
> Modified:
>     llvm/trunk/cmake/modules/HandleLLVMOptions.cmake
>
> Modified: llvm/trunk/cmake/modules/HandleLLVMOptions.cmake
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/HandleLLVMOptions.cmake?rev=360991&r1=360990&r2=360991&view=diff
>
> ==============================================================================
> --- llvm/trunk/cmake/modules/HandleLLVMOptions.cmake (original)
> +++ llvm/trunk/cmake/modules/HandleLLVMOptions.cmake Thu May 16 23:07:37
> 2019
> @@ -920,14 +920,10 @@ endif()
>
>  # Plugin support
>  # FIXME: Make this configurable.
> -if(WIN32 OR CYGWIN)
> -  if(BUILD_SHARED_LIBS OR LLVM_BUILD_LLVM_DYLIB)
> -    set(LLVM_ENABLE_PLUGINS ON)
> -  else()
> -    set(LLVM_ENABLE_PLUGINS OFF)
> -  endif()
> -else()
> +if(BUILD_SHARED_LIBS OR LLVM_BUILD_LLVM_DYLIB)
>    set(LLVM_ENABLE_PLUGINS ON)
> +else()
> +  set(LLVM_ENABLE_PLUGINS OFF)
>  endif()
>
>  # By default we should enable LLVM_ENABLE_IDE only for multi-configuration
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190520/c5bf992c/attachment.html>