<div dir="ltr"><div dir="ltr"><div>Since the buildbots typically don't set BUILD_SHARED_LIBS OR<br></div><div>LLVM_BUILD_LLVM_DYLIB, this change prevents them from building</div><div>are testing any plugins.  It also makes it impossible to</div><div>override, so I'm unable to even test bugpoint locally without</div><div>switching to shared libraries. </div><div><br></div><div>Therefore, I'd like to revert part of it.  Please see <a href="https://reviews.llvm.org/D62154">https://reviews.llvm.org/D62154</a></div><div><br></div><div>Here'a an example of the messages from the bots:</div><div><br></div><div>from <a href="http://lab.llvm.org:8011/builders/clang-atom-d525-fedora-rel/builds/24462/steps/cmake%20stage%201/logs/stdio">http://lab.llvm.org:8011/builders/clang-atom-d525-fedora-rel/builds/24462/steps/cmake%20stage%201/logs/stdio</a></div><div><span style="color:rgb(0,0,0);font-family:"courier new",monospace"><br></span></div><div><span style="color:rgb(0,0,0);font-family:"courier new",monospace">-- PrintFunctionNames ignored -- Loadable modules not supported on this platform.</span><br></div><div><span style="font-family:"courier new",monospace;color:rgb(0,0,0)">-- AnnotateFunctions ignored -- Loadable modules not supported on this platform.</span></div><div><span style="font-family:"courier new",monospace;color:rgb(0,0,0)">-- SampleAnalyzerPlugin ignored -- Loadable modules not supported on this platform.</span></div><div><span style="font-family:"courier new",monospace;color:rgb(0,0,0)">-- CheckerDependencyHandlingAnalyzerPlugin ignored -- Loadable modules not supported on this platform.</span></div><div><span style="font-family:"courier new",monospace;color:rgb(0,0,0)">-- CheckerOptionHandlingAnalyzerPlugin ignored -- Loadable modules not supported on this platform.</span></div><div><span style="font-family:"courier new",monospace;color:rgb(0,0,0)">-- BugpointPasses ignored -- Loadable modules not supported on this platform.</span></div><div><span style="font-family:"courier new",monospace;color:rgb(0,0,0)">-- TestPlugin ignored -- Loadable modules not supported on this platform.</span></div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, May 16, 2019 at 11:04 PM Petr Hosek via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Author: phosek<br>
Date: Thu May 16 23:07:37 2019<br>
New Revision: 360991<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=360991&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=360991&view=rev</a><br>
Log:<br>
[Analysis] Only run plugins tests if plugins are actually enabled<br>
<br>
When plugins aren't enabled, don't try to run plugins tests. Don't<br>
enable plugins unconditionally based on the platform, instead check<br>
if LLVM shared library is actually being built which may not be the<br>
case for every host configuration, even if the host itself supports<br>
plugins.<br>
<br>
This addresses test failures introduced by r360891/D59464.<br>
<br>
Differential Revision: <a href="https://reviews.llvm.org/D62050" rel="noreferrer" target="_blank">https://reviews.llvm.org/D62050</a><br>
<br>
Modified:<br>
    llvm/trunk/cmake/modules/HandleLLVMOptions.cmake<br>
<br>
Modified: llvm/trunk/cmake/modules/HandleLLVMOptions.cmake<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/HandleLLVMOptions.cmake?rev=360991&r1=360990&r2=360991&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/HandleLLVMOptions.cmake?rev=360991&r1=360990&r2=360991&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/cmake/modules/HandleLLVMOptions.cmake (original)<br>
+++ llvm/trunk/cmake/modules/HandleLLVMOptions.cmake Thu May 16 23:07:37 2019<br>
@@ -920,14 +920,10 @@ endif()<br>
<br>
 # Plugin support<br>
 # FIXME: Make this configurable.<br>
-if(WIN32 OR CYGWIN)<br>
-  if(BUILD_SHARED_LIBS OR LLVM_BUILD_LLVM_DYLIB)<br>
-    set(LLVM_ENABLE_PLUGINS ON)<br>
-  else()<br>
-    set(LLVM_ENABLE_PLUGINS OFF)<br>
-  endif()<br>
-else()<br>
+if(BUILD_SHARED_LIBS OR LLVM_BUILD_LLVM_DYLIB)<br>
   set(LLVM_ENABLE_PLUGINS ON)<br>
+else()<br>
+  set(LLVM_ENABLE_PLUGINS OFF)<br>
 endif()<br>
<br>
 # By default we should enable LLVM_ENABLE_IDE only for multi-configuration<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>