[PATCH] D61705: Tablegen type comparison LE should be LT or equal.

Pete Couperus via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 8 16:10:43 PDT 2019


petecoup marked an inline comment as done.
petecoup added inline comments.


================
Comment at: llvm/utils/TableGen/CodeGenDAGPatterns.cpp:517
-    // Note on the < comparison below:
-    // X86 has patterns like
-    //   (set VR128X:$dst, (v16i8 (X86vtrunc (v4i32 VR128X:$src1)))),
----------------
Krzysztof, I believe you made this change?  I was not able to find these trunc patterns in the X86 backend, and all the default backends seem to build/test fine with my change here.  Can you comment on whether this looks OK to you?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61705/new/

https://reviews.llvm.org/D61705





More information about the llvm-commits mailing list