[PATCH] D61636: [llvm-objcopy] - Fix for "Bug 41775 - SymbolTableSection::addSymbol - shadow variable names"

[George Rimar via Phabricator via llvm-commits]

grimar marked an inline comment as done.
grimar added inline comments.


================
Comment at: tools/llvm-objcopy/ELF/Object.cpp:405
                                    uint8_t Visibility, uint16_t Shndx,
                                    uint64_t Size) {
   Symbol Sym;
----------------
jhenderson wrote:
> Maybe a better fix would be to rename this parameter to SymbolSize, to avoid any future confusion?
But it will be not consistent with `Type`, `Value` and others. Doesn't seem we want to
rename all of those to `SymbolType`, `SymbolValue` etc?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61636/new/

https://reviews.llvm.org/D61636