[PATCH] D61636: [llvm-objcopy] - Fix for "Bug 41775 - SymbolTableSection::addSymbol - shadow variable names"

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 7 05:37:16 PDT 2019


jhenderson added inline comments.


================
Comment at: tools/llvm-objcopy/ELF/Object.cpp:405
                                    uint8_t Visibility, uint16_t Shndx,
                                    uint64_t Size) {
   Symbol Sym;
----------------
Maybe a better fix would be to rename this parameter to SymbolSize, to avoid any future confusion?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61636/new/

https://reviews.llvm.org/D61636





More information about the llvm-commits mailing list