[PATCH] D61520: Update PatternMatcher to match both FNeg(X) and FSub(+-0.0, X) in FNeg_match

Cameron McInally via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 3 09:53:21 PDT 2019


cameron.mcinally marked 2 inline comments as done.
cameron.mcinally added inline comments.


================
Comment at: llvm/unittests/IR/PatternMatch.cpp:605
+  EXPECT_TRUE(match(V, m_FNeg(m_Value(Match))));
+  EXPECT_EQ(O, Match);
+
----------------
spatel wrote:
> Nit: I thought that was a zero on first look rather than an 'O'. Porbably better to spell that out as "One".
Sorry, I missed this comment in the Phab email. Will update now...


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61520/new/

https://reviews.llvm.org/D61520





More information about the llvm-commits mailing list