[PATCH] D61520: Update PatternMatcher to match both FNeg(X) and FSub(+-0.0, X) in FNeg_match

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 3 09:32:19 PDT 2019


spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM - thanks for splitting it off.



================
Comment at: llvm/unittests/IR/PatternMatch.cpp:605
+  EXPECT_TRUE(match(V, m_FNeg(m_Value(Match))));
+  EXPECT_EQ(O, Match);
+
----------------
Nit: I thought that was a zero on first look rather than an 'O'. Porbably better to spell that out as "One".


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61520/new/

https://reviews.llvm.org/D61520





More information about the llvm-commits mailing list