[PATCH] D61387: [CMake][benchmark] Cache result of CXXFeatureCheck

Chris Bieneman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 1 14:21:24 PDT 2019


beanz added a comment.

@lebedev.ri I actually disagree with prefixing capabilities check variables. If other projects are checking the same thing you want them to use the same variable so that they don't all check the same thing over and over again.

Also, why is this duplicated between libcxx, test-suite and llvm? There is functionality in the libcxx build that requires the LLVM CMake modules (like building the tests), so it seems like a better solution would be having this module be a llvm CMake module that is shared across the other projects.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61387/new/

https://reviews.llvm.org/D61387





More information about the llvm-commits mailing list