[PATCH] D61387: [CMake][benchmark] Cache result of CXXFeatureCheck

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 1 12:42:52 PDT 2019


lebedev.ri added a comment.

Also, it's not a great idea to store something into cache/global scope without ensuring unique global prefix, so please change `HAVE_` to `BENCHMARK_HAVE_`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61387/new/

https://reviews.llvm.org/D61387





More information about the llvm-commits mailing list