[PATCH] D61243: Check build-type dependent variables for -flto as well.

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 30 08:51:17 PDT 2019


lebedev.ri added a comment.

In D61243#1484319 <https://reviews.llvm.org/D61243#1484319>, @fhahn wrote:

> In D61243#1481819 <https://reviews.llvm.org/D61243#1481819>, @lebedev.ri wrote:
>
> > Two thoughts:
> >
> > 1. Why is `LDFLAGS` being set conditionally, is there a warning otherwise?
>
>
> I think it is set conditionally, because the selected linker exe may not support it. When doing LTO  and saving stats, the assumption is that people are using clang for linking.


Unless it is intentionally overridden along the way by the user, CMake is always using the compiler as the linker.

>> 2. I wonder, why it's `{C,CXX,LD}FLAGS`, and not `CMAKE_*_FLAGS` directly.
> 
> Not sure, TBH.




Repository:
  rT test-suite

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61243/new/

https://reviews.llvm.org/D61243





More information about the llvm-commits mailing list