[PATCH] D61180: [yaml2obj] - Treat integer symbol names as explicit st_name value.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 29 08:58:47 PDT 2019


grimar added a comment.

In D61180#1482531 <https://reviews.llvm.org/D61180#1482531>, @jhenderson wrote:

> I have a slight concern here, in that the approach prevents us using a name that is actually a number, and that might be confusing. I think we might want to have a different field (e.g. "NameIndex" or similar) explicitly for this situation. One and only one of the two fields can then be specified.
>
> What do you think?


I thought that it is impossible to have a symbol name that is a number. Because valid C name must begin with a letter of the alphabet or an underscore.
I.e. I am not sure we should care about this case. At least now. Should we?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61180/new/

https://reviews.llvm.org/D61180





More information about the llvm-commits mailing list