[PATCH] D61180: [yaml2obj] - Treat integer symbol names as explicit st_name value.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 29 08:39:43 PDT 2019


jhenderson added a comment.

I have a slight concern here, in that the approach prevents us using a name that is actually a number, and that might be confusing. I think we might want to have a different field (e.g. "NameIndex" or similar) explicitly for this situation. One and only one of the two fields can then be specified.

What do you think?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61180/new/

https://reviews.llvm.org/D61180





More information about the llvm-commits mailing list