[PATCH] D59504: [NFC][Sanitizer] Clean up GetRealFunctionAddress

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added a comment.

> This function has evolved over the years. Comment about return value is
>  lying. Paramters real/wrapper don't make much sense and are not supplied
>  at any call site. Real return type is never used.

I guess they are used

  #define ASAN_INTERCEPT_FUNC(name)                                        \
    do {                                                                   \
      if ((!INTERCEPT_FUNCTION(name) || !REAL(name)))                      \
        VReport(1, "AddressSanitizer: failed to intercept '" #name "'\n"); \
    } while (0)

I understand that as weird protection against double intercept

> Refactored to be consistent with GetFuncAddrVer.





================
Comment at: compiler-rt/lib/interception/interception_linux.cc:40
+  if (StrCmp(name, "sigaction"))
+    name = "__sigaction14";
 #endif
----------------
It would be much easier to confirm that this is NFC if it was several patches
1. extract GetFuncAddr from GetRealFunctionAddress
2. Renames
...



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59504/new/

https://reviews.llvm.org/D59504