[PATCH] D59504: [NFC][Sanitizer] Clean up GetRealFunctionAddress

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 24 14:04:41 PDT 2019


vitalybuka added a comment.

Does not compile on linux

  usr/local/google/home/vitalybuka/src/llvm.git/llvm-project/compiler-rt/lib/interception/tests/interception_linux_test.cc:60:2: warning: embedding a directive within macro arguments has undefined behavior [-Wembedded-directive]
  #endif  // SANITIZER_LINUX
   ^
  /usr/local/google/home/vitalybuka/src/llvm.git/llvm-project/compiler-rt/lib/interception/tests/interception_linux_test.cc:61:2: warning: embedding a directive within macro arguments has undefined behavior [-Wembedded-directive]
  #endif  // #if !SANITIZER_DEBUG
   ^
  /usr/local/google/home/vitalybuka/src/llvm.git/llvm-project/compiler-rt/lib/interception/tests/interception_linux_test.cc:38:3: error: unterminated function-like macro invocation
    EXPECT_EQ(GetFuncAddr("dummy_doesnt_exist__", nullptr);
    ^
  /usr/local/google/home/vitalybuka/src/llvm.git/llvm-project/llvm/utils/unittest/googletest/include/gtest/gtest.h:1922:9: note: macro 'EXPECT_EQ' defined here
  #define EXPECT_EQ(val1, val2) \
          ^
  /usr/local/google/home/vitalybuka/src/llvm.git/llvm-project/compiler-rt/lib/interception/tests/interception_linux_test.cc:61:32: error: expected '}'
  #endif  // #if !SANITIZER_DEBUG
                                 ^
  /usr/local/google/home/vitalybuka/src/llvm.git/llvm-project/compiler-rt/lib/interception/tests/interception_linux_test.cc:36:33: note: to match this '{'
  TEST(Interception, GetFuncAddr) {
                                  ^
  /usr/local/google/home/vitalybuka/src/llvm.git/llvm-project/compiler-rt/lib/interception/tests/interception_linux_test.cc:61:32: error: expected '}'
  #endif  // #if !SANITIZER_DEBUG
                                 ^
  /usr/local/google/home/vitalybuka/src/llvm.git/llvm-project/compiler-rt/lib/interception/tests/interception_linux_test.cc:34:26: note: to match this '{'
  namespace __interception {


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59504/new/

https://reviews.llvm.org/D59504





More information about the llvm-commits mailing list