[PATCH] D60382: FileCheck [2/12]: Stricter parsing of -D option

Wed Apr 17 02:42:00 PDT 2019

jhenderson added a comment.

I have only one more minor comment. Happy for this to go in with or without it, but @probinson should give the final thumbs up.

================
Comment at: llvm/test/FileCheck/defines.txt:38
+
+; ERRCLIFMT: Global defines:1:1: error: Invalid name for variable definition '10VALUE'
+; ERRCLIFMT-NEXT: 10VALUE=10
----------------
The line and column numbers like a bit weird to me, but isn't a big deal. If there's a way to not have them though, it would be better. Alternatively, if they have some actual meaning, please have a test case that produces different values for them.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60382/new/

https://reviews.llvm.org/D60382