[PATCH] D60382: FileCheck [2/12]: Stricter parsing of -D option

Thomas Preud'homme via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 17 02:22:41 PDT 2019


thopre updated this revision to Diff 195525.
thopre marked 8 inline comments as done.
thopre added a comment.

- Make diagnostic for command-line global define parsing more neutral wrt. user of the FileCheck library
- Use StringRef in the loop for command-line global define parsing
- Fix wording of comment for @LINE parsing


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60382/new/

https://reviews.llvm.org/D60382

Files:
  llvm/include/llvm/Support/FileCheck.h
  llvm/lib/Support/FileCheck.cpp
  llvm/test/FileCheck/defines.txt
  llvm/unittests/Support/FileCheckTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60382.195525.patch
Type: text/x-patch
Size: 14834 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190417/84e962c5/attachment.bin>


More information about the llvm-commits mailing list