[PATCH] D32530: [SVE][IR] Scalable Vector IR Type

Wed Apr 3 07:21:47 PDT 2019

sebpop added a comment.

In D32530#1452773 <https://reviews.llvm.org/D32530#1452773>, @rovka wrote:

> In D32530#1451505 <https://reviews.llvm.org/D32530#1451505>, @lebedev.ri wrote:
>
> > I'd advise caution here, it's really significant/impactful change, and a single sign-off is a bit worrying.
>

There were several people who voted for a scalable vector type in the llvm-dev thread that I referred to
http://lists.llvm.org/pipermail/llvm-dev/2019-March/131137.html
Maybe those people can also sign-off to accept this change.

I am somewhat against extending the IR with the SV type
and I recognize that as we stand today adding the SV type is a good way to get ARM-SVE support in LLVM.

> I agree that this is a significant change and I can understand why people are a bit nervous about merging it. Would it help if we had more middle-end patches reviewed before committing, so people could have a better understanding of the impact? Off the top of my head, the rework of D35137 <https://reviews.llvm.org/D35137> would be interesting, and also constant handling.
> 
> Can you also tell us what the plan is regarding all the places in the optimizer that may need updating to handle the new vectors?

A patch series has been posted for review, see section 7. in
http://lists.llvm.org/pipermail/llvm-dev/2018-June/123780.html

> 
> 
>> In particular, even regardless of the feature itself, has the implementation itself been reviewed?
> 
> I can't speak for Sebastian, but there have been a few pairs of eyes on the implementation itself, as you can see from the comments.

Yes, I have reviewed the current patch and I have looked at the patch series.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D32530/new/

https://reviews.llvm.org/D32530