[PATCH] D32530: [SVE][IR] Scalable Vector IR Type

[Diana Picus via Phabricator via llvm-commits]

rovka added a comment.

In D32530#1451505 <https://reviews.llvm.org/D32530#1451505>, @lebedev.ri wrote:

> I'd advise caution here, it's really significant/impactful change, and a single sign-off is a bit worrying.


I agree that this is a significant change and I can understand why people are a bit nervous about merging it. Would it help if we had more middle-end patches reviewed before committing, so people could have a better understanding of the impact? Off the top of my head, the rework of D35137 <https://reviews.llvm.org/D35137> would be interesting, and also constant handling.

Can you also tell us what the plan is regarding all the places in the optimizer that may need updating to handle the new vectors? AFAICT, code that deals only with fixed-width vectors shouldn't be affected, but I would imagine a lot of passes would break IR using scalable vectors (e.g. by building fixed-width vectors instead of scalable ones).

> In particular, even regardless of the feature itself, has the implementation itself been reviewed?

I can't speak for Sebastian, but there have been a few pairs of eyes on the implementation itself, as you can see from the comments.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D32530/new/

https://reviews.llvm.org/D32530