[PATCH] D59535: [SelectionDAG] Compute known bits of CopyFromReg

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 19 01:27:58 PDT 2019


lebedev.ri added inline comments.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:19513
 
-  // If the operand types disagree, extend the shift amount to match.  Since
-  // BT ignores high bits (like shifts) we can use anyextend.
-  if (Src.getValueType() != BitNo.getValueType())
+  // If the operand types disagree, extend or truncate the shift amount to match.
+  // Since BT ignores high bits (like shifts) we can use anyextend for the extension.
----------------
Does it trigger any tests without the rest of the diff?
Does this *have* to be in the same diff as the other part of the diff?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59535/new/

https://reviews.llvm.org/D59535





More information about the llvm-commits mailing list