[PATCH] D59445: Restore comment regarding why Reloc::PIC_ can't be PIC

[Phabricator via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL356402: Restore comment regarding why Reloc::PIC_ can't be PIC (authored by sbc, committed by ).
Herald added a subscriber: kristina.

Changed prior to commit:
  https://reviews.llvm.org/D59445?vs=190939&id=191150#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59445/new/

https://reviews.llvm.org/D59445

Files:
  llvm/trunk/include/llvm/Support/CodeGen.h


Index: llvm/trunk/include/llvm/Support/CodeGen.h
===================================================================
--- llvm/trunk/include/llvm/Support/CodeGen.h
+++ llvm/trunk/include/llvm/Support/CodeGen.h
@@ -18,13 +18,14 @@
 
   // Relocation model types.
   namespace Reloc {
-  enum Model { Static, PIC_, DynamicNoPIC, ROPI, RWPI, ROPI_RWPI };
+    // Cannot be named PIC due to collision with -DPIC
+    enum Model { Static, PIC_, DynamicNoPIC, ROPI, RWPI, ROPI_RWPI };
   }
 
   // Code model types.
   namespace CodeModel {
     // Sync changes with CodeGenCWrappers.h.
-  enum Model { Tiny, Small, Kernel, Medium, Large };
+    enum Model { Tiny, Small, Kernel, Medium, Large };
   }
 
   namespace PICLevel {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D59445.191150.patch
Type: text/x-patch
Size: 721 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190318/464048a9/attachment.bin>