[llvm] r356402 - Restore comment regarding why Reloc::PIC_ can't be PIC

Sam Clegg via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 18 13:04:35 PDT 2019


Author: sbc
Date: Mon Mar 18 13:04:34 2019
New Revision: 356402

URL: http://llvm.org/viewvc/llvm-project?rev=356402&view=rev
Log:
Restore comment regarding why Reloc::PIC_ can't be PIC

The original change back in rL29307 explained this but it was
lost somewhere along the way.

Differential Revision: https://reviews.llvm.org/D59445

Modified:
    llvm/trunk/include/llvm/Support/CodeGen.h

Modified: llvm/trunk/include/llvm/Support/CodeGen.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/CodeGen.h?rev=356402&r1=356401&r2=356402&view=diff
==============================================================================
--- llvm/trunk/include/llvm/Support/CodeGen.h (original)
+++ llvm/trunk/include/llvm/Support/CodeGen.h Mon Mar 18 13:04:34 2019
@@ -18,13 +18,14 @@ namespace llvm {
 
   // Relocation model types.
   namespace Reloc {
-  enum Model { Static, PIC_, DynamicNoPIC, ROPI, RWPI, ROPI_RWPI };
+    // Cannot be named PIC due to collision with -DPIC
+    enum Model { Static, PIC_, DynamicNoPIC, ROPI, RWPI, ROPI_RWPI };
   }
 
   // Code model types.
   namespace CodeModel {
     // Sync changes with CodeGenCWrappers.h.
-  enum Model { Tiny, Small, Kernel, Medium, Large };
+    enum Model { Tiny, Small, Kernel, Medium, Large };
   }
 
   namespace PICLevel {




More information about the llvm-commits mailing list