[PATCH] D58784: [FileCheck]Remove assertions that prevent matching an empty string at file start before CHECK-NEXT/SAME

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 12 06:50:23 PDT 2019


probinson accepted this revision.
probinson added a comment.

I am convinced that the asserts are wrong, and that we currently get diags for NEXT/SAME/EMPTY at the top.  So LGTM to remove the asserts.

The leading semicolons in the test are noise, please remove those.  Writing FileCheck tests is tricky and I'd prefer not to have anything in them that implies FileCheck itself will ignore part of the file.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58784/new/

https://reviews.llvm.org/D58784





More information about the llvm-commits mailing list