[PATCH] D58784: [FileCheck]Remove assertions that prevent matching an empty string at file start before CHECK-NEXT/SAME

Tue Mar 12 03:14:52 PDT 2019

jhenderson added a comment.

In D58784#1424646 <https://reviews.llvm.org/D58784#1424646>, @jdenny wrote:

> Has anyone raised a solid objection to this patch?  If not, I see no reason to delay it further.  We can always add replacement assertions later.
>
> This patch does not enable initial `CHECK-{SAME,NEXT,EMPTY}`.  I don't recall a pressing need for a directive that matches only the first line, and we don't seem to be converging on whether it should be one of those or some new directive.  Maybe we should take a step back for a while and try this discussion again later.

@probinson?

If we want to discuss further, I think the mailing list is the better place for it, since it will get better visibility there, and it's only tangentially related to this change.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58784/new/

https://reviews.llvm.org/D58784