[PATCH] D59126: llvm-objcopy: Remove unused field. NFCI.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 8 12:26:55 PST 2019


pcc added a comment.

An alternative to storing this field in Segment would be to store a reference to the file contents as a field in Object. That would allow you to access the segment contents using the OriginalOffset and Size fields, and also seems like it might allow you to remove the various Contents fields from the Section hierarchy. So maybe we should remove this field in case that approach turns out to work out better?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59126/new/

https://reviews.llvm.org/D59126





More information about the llvm-commits mailing list