[PATCH] D59126: llvm-objcopy: Remove unused field. NFCI.

[James Henderson via Phabricator via llvm-commits]

jhenderson requested changes to this revision.
jhenderson added a comment.
This revision now requires changes to proceed.

Right, I did lots of digging and discovered that this was added originally for binary output support, in rL310127 <https://reviews.llvm.org/rL310127>. The usage was removed when binary output support was changed to be driven by segments in r318324. It was never used for regular ELF output, but I think it should be.

I've discussed with a colleague and we definitely need the behaviour of preserving unlabelled space within program headers. As such, we will need the data. I or one of my colleagues will be looking at implementing this in the next few days, so please don't commit this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59126/new/

https://reviews.llvm.org/D59126