[PATCH] D58911: DAG: Don't break value dependencies when sorting loads by offset

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 4 10:31:56 PST 2019


rampitec added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/ScheduleDAGSDNodes.cpp:270
+    // dependencies between some of the loads. Sort them when asking the target.
+    int64_t LowOffset = std::min(BaseOff, Offset);
+    int64_t HighOffset = std::max(BaseOff, Offset);
----------------
Isn't that easier and cleaner to compute new BaseOff once yet while sorting?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58911/new/

https://reviews.llvm.org/D58911





More information about the llvm-commits mailing list