[PATCH] D58102: Support X86 Control-flow Enforcement Technology (CET) in LLD

Eric Christopher via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 25 23:54:49 PST 2019


echristo added a comment.

In D58102#1408397 <https://reviews.llvm.org/D58102#1408397>, @xiangzhangllvm wrote:

> Hi ruiu, very thank you for considering accepting the 2-PLT ABI design in X86 arch, Yes, we really have no real measurable evidence for the benefit of this design, and I also think there must be other problems for the CET here, but it is just the beginning. We will work on improving and refining it.
>  Your questions and suggestions during the discussion were all very much to the point.
>  I'll first to implement your first 2 review suggestions above.
>  Thank you again!


Wait, I thought this was going in because it was already part of the ABI not an experimental WIP. Which is it? :)

I'm also less convinced of the utility of this ABI extension and would like to hear about the appropriate discussions. I don't think I saw them on the list, but I could be mistaken. What's up here? What's going on with the use of gnu note sections rather than any other part of the ELF abi? If we can, I think there should be a longer discussion about both the motivation and implementation of this feature.

Thanks!

-eric


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58102/new/

https://reviews.llvm.org/D58102





More information about the llvm-commits mailing list