[PATCH] D58102: Support X86 Control-flow Enforcement Technology (CET) in LLD

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

I'd think you should add a new linker command line flag to enforce CET from the initial patch as I suggested earlier. Security measures should not be automatically turned off, so the behavior implemented in this patch seems little dangerous.

The other reason why I want to see that in the initial patch is that I believe adding that flag makes code actually simpler. With a command line flag, you wouldn't need to "merge" .note section attributes. You would only need to check if an input file has a required bit in a .note section when reading a file (if not, report an error), and you can always emit a .note section of the same contents from the linker to enable CET.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58102/new/

https://reviews.llvm.org/D58102