[PATCH] D58528: [AArch64][GlobalISel] Refactor selectBuildVector to use MachineIRBuilder. NFC.

[Jessica Paquette via Phabricator via llvm-commits]

paquette accepted this revision.
paquette added a comment.
This revision is now accepted and ready to land.

LGTM other than some formatting stuff which doesn't really matter. If clang-format did it, then I have no power to argue against it.



================
Comment at: llvm/lib/Target/AArch64/AArch64InstructionSelector.cpp:1720-1722
+    auto Ins =
+        MIRBuilder
+            .buildInstr(TargetOpcode::INSERT_SUBREG, {DstRC}, {Undef, Scalar})
----------------
Did clang-format actually do this?


================
Comment at: llvm/lib/Target/AArch64/AArch64InstructionSelector.cpp:2097-2100
+      auto InsElt = MIRBuilder.buildInstr(Opc, {InsDef}, {DstVec})
+        .addImm(LaneIdx)
+        .addUse(InsSub.getReg(0))
+        .addImm(0);
----------------
Formatting looks odd here? In my experience, clang-format would probably indent the .addWhatevers, but meh who knows


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58528/new/

https://reviews.llvm.org/D58528