[PATCH] D58439: [obj2yaml][yaml2obj]Locate all tests, including .yaml and .test

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 20 06:40:17 PST 2019


grimar added a comment.

This looks fine, very nice catch, btw!

Have a question though. 
I looked around in llvm and it seems the common practice is to override the lists.
Maybe we should just do `config.suffixes = ['.test', '.yaml']` too?
I would not expect to see other suffixes in test/tools/yaml2obj and test/tools/obj2yaml.
Moreover, when I think about other suffixes it seems it might happen only because of a mistake to me.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58439/new/

https://reviews.llvm.org/D58439





More information about the llvm-commits mailing list