[PATCH] D58439: [obj2yaml][yaml2obj]Locate all tests, including .yaml and .test

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 20 06:31:52 PST 2019


jhenderson requested review of this revision.
jhenderson added a comment.

Turns out that the yaml2obj config file was also broken, and I just traded one bad thing for another. The suffixes list was being completely overwritten by a list containing only '.yaml', so only tests ending in .yaml were being run. This meant that we replaced 3 running tests with 5, when it should in fact be 8 in obj2yaml. I've fixed the yaml2obj config here too, increasing the number of tests from 27 to 29.

@grimar, please could you review again, since this is again!


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58439/new/

https://reviews.llvm.org/D58439





More information about the llvm-commits mailing list