[PATCH] D58416: [llvm-cxxfilt] Split and demangle stdin input on certain non-alphanumerics.

Matt Davis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 19 17:17:34 PST 2019


mattd marked 2 inline comments as done.
mattd added inline comments.


================
Comment at: llvm/tools/llvm-cxxfilt/llvm-cxxfilt.cpp:125
+    SplitStringDelims(Mangled, Words, IsLegalItaniumChar);
+    for (auto &Word : Words)
+      Result += demangle(OS, Word.first) + Word.second.str();
----------------
compnerd wrote:
> Shouldn't this be `const auto &`
Yes it should be const.  I have corrected my local copy.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58416/new/

https://reviews.llvm.org/D58416





More information about the llvm-commits mailing list