[PATCH] D58416: [llvm-cxxfilt] Split and demangle stdin input on certain non-alphanumerics.

Matt Davis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 19 16:49:37 PST 2019


mattd added a comment.

In D58416#1403227 <https://reviews.llvm.org/D58416#1403227>, @compnerd wrote:

> Previously we would have emitted `Foo [[:space:]] .` right?


Thanks for the feedback.  Previously we emitted a literal space character, ' ', between the mangled terms that were split on [[:space:]].  This means that tabs would get replaced with single spaces when reassembling the demangled string.  With this patch, we now delimit on a variety of non-space delimiters, and capture the delimiter.  This patch correctly reassembles the string using the captured delimiter... not just a single space.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58416/new/

https://reviews.llvm.org/D58416





More information about the llvm-commits mailing list