[PATCH] D52954: Annotate timeline in Instruments with passes and other timed regions.

[Daniel Sanders via Phabricator via llvm-commits]

dsanders marked an inline comment as done.
dsanders added inline comments.


================
Comment at: cmake/modules/HandleLLVMOptions.cmake:893
+
+option(LLVM_SUPPORT_XCODE_SIGNPOSTS "Enable support for Xcode signposts" OFF)
----------------
bogner wrote:
> dsanders wrote:
> > bogner wrote:
> > > Can we detect when this is available rather than make it an option?
> > We can test for os_signpost_interval_begin() and only offer it when it's available but I think it should be optional. The os_signpost family are very cheap (mostly due to the constant literal string requirements) but they do have a run-time cost.
> Makes sense, though I think defaulting the option to on when it's available makes sense. It may also make sense to default this to match asserts and allow it to be forced on or off (that's done elsewhere, IIRC)
I've gone with the WITH_ASSERTS mechanism like ABI-breaking checks


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D52954/new/

https://reviews.llvm.org/D52954