[PATCH] D52954: Annotate timeline in Instruments with passes and other timed regions.

[Justin Bogner via Phabricator via llvm-commits]

bogner added inline comments.


================
Comment at: cmake/modules/HandleLLVMOptions.cmake:893
+
+option(LLVM_SUPPORT_XCODE_SIGNPOSTS "Enable support for Xcode signposts" OFF)
----------------
dsanders wrote:
> bogner wrote:
> > Can we detect when this is available rather than make it an option?
> We can test for os_signpost_interval_begin() and only offer it when it's available but I think it should be optional. The os_signpost family are very cheap (mostly due to the constant literal string requirements) but they do have a run-time cost.
Makes sense, though I think defaulting the option to on when it's available makes sense. It may also make sense to default this to match asserts and allow it to be forced on or off (that's done elsewhere, IIRC)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D52954/new/

https://reviews.llvm.org/D52954