[PATCH] D57316: [LoopSimplifyCFG] Use DT.update instead of DTU

[Jakub Kuderski via Phabricator via llvm-commits]

kuhar added a comment.

In D57316#1387482 <https://reviews.llvm.org/D57316#1387482>, @kuhar wrote:

> In D57316#1386640 <https://reviews.llvm.org/D57316#1386640>, @mkazantsev wrote:
>
> > I've given up using DTU, now the updates are applied directly.
>
>
> Max, why don't you use DTU with `.applyUpdates`? Are you facing some difficulties, or found documentation confusing somewhere else?
>  I don't have much time recently, but I can definitely find enough to fix some issues people have with updating dominators. If you think something is not obvious or too difficult, there are probably multiple people who faced the same problems but never bother to share their experience.


The goal of DTU is take away as much low-level burden when updating dominators as possible. Ideally, nobody should have to use the raw updater in DomTree anymore, and the DTU api should enable us to cheaply update PostDominators without modifying the update logic.
That's why I'm opposed to using raw updates, unless absolutely necessary.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57316/new/

https://reviews.llvm.org/D57316